[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] nbd: add missed aio_context_acquire in nbd_
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] nbd: add missed aio_context_acquire in nbd_export_new |
Date: |
Tue, 26 Jan 2016 12:37:15 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 20/01/2016 08:12, Denis V. Lunev wrote:
> blk_invalidate_cache() can call qcow2_invalidate_cache which performs
> IO inside.
>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Kevin Wolf <address@hidden>
> CC: Paolo Bonzini <address@hidden>
> ---
> nbd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/nbd.c b/nbd.c
> index b3d9654..b271db5 100644
> --- a/nbd.c
> +++ b/nbd.c
> @@ -1080,7 +1080,9 @@ NBDExport *nbd_export_new(BlockBackend *blk, off_t
> dev_offset, off_t size,
> * that BDRV_O_INCOMING is cleared and the image is ready for write
> * access since the export could be available before migration handover.
> */
> + aio_context_acquire(exp->ctx);
> blk_invalidate_cache(blk, NULL);
> + aio_context_release(exp->ctx);
> return exp;
>
> fail:
>
Queuing this one myself.
Paolo