[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 2/3] quorum: implement bdrv_add_child() and b
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [PATCH v9 2/3] quorum: implement bdrv_add_child() and bdrv_del_child() |
Date: |
Wed, 20 Jan 2016 16:43:45 +0100 |
User-agent: |
Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) |
On Fri 25 Dec 2015 10:22:55 AM CET, Changlong Xie wrote:
> @@ -875,9 +878,9 @@ static int quorum_open(BlockDriverState *bs, QDict
> *options, int flags,
> ret = -EINVAL;
> goto exit;
> }
> - if (s->num_children < 2) {
> + if (s->num_children < 1) {
> error_setg(&local_err,
> - "Number of provided children must be greater than 1");
> + "Number of provided children must be 1 or more");
> ret = -EINVAL;
> goto exit;
> }
I have a question: if you have a Quorum with just one member and you add
a new one, how do you know if it has the same data as the existing one?
In general, what do you do to make sure that the data in a new Quorum
child is consistent with that of the rest of the array?
Berto
- Re: [Qemu-devel] [PATCH v9 2/3] quorum: implement bdrv_add_child() and bdrv_del_child(),
Alberto Garcia <=