[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 15/15] qemu-char: do not leak QemuMutex when freeing
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 15/15] qemu-char: do not leak QemuMutex when freeing a character device |
Date: |
Fri, 15 Jan 2016 17:04:31 +0100 |
The leak is only apparent on Win32. On POSIX platforms destroying a
mutex is not necessary.
Reported-by: Eric Blake <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
qemu-char.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qemu-char.c b/qemu-char.c
index 11caa56..e133f4f 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -3972,6 +3972,7 @@ static void qemu_chr_free_common(CharDriverState *chr)
if (chr->logfd != -1) {
close(chr->logfd);
}
+ qemu_mutex_destroy(&chr->chr_write_lock);
g_free(chr);
}
--
1.8.3.1
- Re: [Qemu-devel] [PULL 03/15] i386: avoid null pointer dereference, (continued)
[Qemu-devel] [PULL 12/15] nbd-server: do not check request length except for reads and writes, Paolo Bonzini, 2016/01/15
[Qemu-devel] [PULL 06/15] qemu-char: delete send_all/recv_all helper methods, Paolo Bonzini, 2016/01/15
[Qemu-devel] [PULL 13/15] nbd-server: do not exit on failed memory allocation, Paolo Bonzini, 2016/01/15
[Qemu-devel] [PULL 10/15] nbd: Split nbd.c, Paolo Bonzini, 2016/01/15
[Qemu-devel] [PULL 09/15] nbd: Always call "close_fn" in nbd_client_new, Paolo Bonzini, 2016/01/15
[Qemu-devel] [PULL 08/15] SCSI device: fix to incomplete QOMify, Paolo Bonzini, 2016/01/15
[Qemu-devel] [PULL 15/15] qemu-char: do not leak QemuMutex when freeing a character device,
Paolo Bonzini <=
[Qemu-devel] [PULL 11/15] nbd-server: Coroutine based negotiation, Paolo Bonzini, 2016/01/15
[Qemu-devel] [PULL 14/15] qemu-char: add logfile facility to all chardev backends, Paolo Bonzini, 2016/01/15
Re: [Qemu-devel] [PULL 00/15] NBD, chardev, SCSI patches for 2015-01-15, Peter Maydell, 2016/01/15