Re: [Qemu-devel] [PATCH v2] pc: allow raising low memory via max-ram-below-4g option

[Eric Blake]

On 01/08/2016 05:58 AM, Gerd Hoffmann wrote:
> This patch extends the functionality of the max-ram-below-4g option
> to also allow increasing lowmem.  Use case: Give as much memory as
> possible to legacy non-PAE guests.
> 
> While being at it also rework the lowmem calculation logic and add a
> longish comment describing how it works and what the compatibility
> constrains are.

s/constrains/constraints/

> 
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---

> +            if (lowmem & ((1ULL << 30) - 1)) {
> +                error_report("Warning: Large machine and max_ram_below_4g "
> +                             "(%" PRIu64 ") not a multiple of 1G; "
> +                             "possible bad performance.",

No trailing '.' in error_report(), please.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature