Re: [Qemu-devel] [PATCH v2 0/2] qga: guest-set-user-password - added ability to create new user

[Marc-André Lureau]

Hi

On Wed, Jan 6, 2016 at 1:01 PM, Denis V. Lunev <address@hidden> wrote:
> These patches add optional 'create' flag to guest-set-user-password command.
> When it is specified, a new user will be created if it does not
> exist yet.
>

What's the motivation to re-use set-password instead of a new command?

> Since v1:
> - fixed english language mistakes in comments
> - json description now mentions 'create' as default to false
> - capture stdout/stderr from useradd/chpasswd and send iti back with the
>   error message to caller
> - split to two patches
>
> Signed-off-by: Yuri Pudgorodskiy <address@hidden>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Eric Blake <address@hidden>
> CC: Michael Roth <address@hidden>
>
> Yuriy Pudgorodskiy (2):
>   create ga_run_program() helper for guest-set-user-password
>   guest-set-user-password - added ability to create new user
>
>  qga/commands-posix.c | 215 
> +++++++++++++++++++++++++++++++++++++--------------
>  qga/commands-win32.c |  25 +++++-
>  qga/qapi-schema.json |   5 +-
>  3 files changed, 186 insertions(+), 59 deletions(-)
>
> --
> 2.1.4
>
>



-- 
Marc-André Lureau