[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 8/9] virtio-ccw: fix sanity check for vector
From: |
Cornelia Huck |
Subject: |
[Qemu-devel] [PULL 8/9] virtio-ccw: fix sanity check for vector |
Date: |
Wed, 13 Jan 2016 16:01:43 +0100 |
From: Halil Pasic <address@hidden>
The commit 8dfbaa6ac ("virtio-ccw: introduce ccw specific queue limit")
did not touch the sanity check for the vector argument of the method
virtio_ccw_notify, despite intended as seen from
https://lists.nongnu.org/archive/html/qemu-devel/2015-04/msg02705.html
To be able to scale number of virtqueues using the constant this sanity
check needs to be altered.
Fixes: 8dfbaa6ac ("virtio-ccw: introduce ccw specific queue limit")
Reviewed-by: Cornelia Huck <address@hidden>
Signed-off-by: Halil Pasic <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>
---
hw/s390x/virtio-ccw.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
index 63da303..95a6c14 100644
--- a/hw/s390x/virtio-ccw.c
+++ b/hw/s390x/virtio-ccw.c
@@ -1177,7 +1177,8 @@ static void virtio_ccw_notify(DeviceState *d, uint16_t
vector)
SubchDev *sch = dev->sch;
uint64_t indicators;
- if (vector >= 128) {
+ /* queue indicators + secondary indicators */
+ if (vector >= VIRTIO_CCW_QUEUE_MAX + 64) {
return;
}
--
2.7.0
- [Qemu-devel] [PULL 0/9] First set of s390x patches for 2.6, Cornelia Huck, 2016/01/13
- [Qemu-devel] [PULL 8/9] virtio-ccw: fix sanity check for vector,
Cornelia Huck <=
- [Qemu-devel] [PULL 2/9] s390x: remove s390-virtio machine, Cornelia Huck, 2016/01/13
- [Qemu-devel] [PULL 5/9] s390x/pci: code cleanup, Cornelia Huck, 2016/01/13
- [Qemu-devel] [PULL 1/9] s390x: add 2.6 compat machine, Cornelia Huck, 2016/01/13
- [Qemu-devel] [PULL 6/9] s390x/virtio: use qemu_check_nic_model(), Cornelia Huck, 2016/01/13
- [Qemu-devel] [PULL 7/9] s390: Introduce CCW_COMPAT_2_5, Cornelia Huck, 2016/01/13
- [Qemu-devel] [PULL 4/9] s390x/pci: reject some operations to disabled PCI function, Cornelia Huck, 2016/01/13
- [Qemu-devel] [PULL 9/9] s390x/pci: return real state during listing PCI, Cornelia Huck, 2016/01/13
- [Qemu-devel] [PULL 3/9] s390x: remove s390-virtio devices, Cornelia Huck, 2016/01/13
- Re: [Qemu-devel] [PULL 0/9] First set of s390x patches for 2.6, Peter Maydell, 2016/01/14