[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 01/11] macio: fix overflow in lba to offset conver
From: |
John Snow |
Subject: |
[Qemu-devel] [PULL v2 01/11] macio: fix overflow in lba to offset conversion for ATAPI devices |
Date: |
Mon, 11 Jan 2016 14:33:50 -0500 |
From: Mark Cave-Ayland <address@hidden>
As the IDEState lba field is an int32_t, make sure we cast to int64_t before
shifting to calculate the offset. Otherwise we end up with an overflow when
trying to access sectors beyond 2GB as can occur when using DVD images.
[Maintainer edit: fixed extraneous parentheses. --js]
Signed-off-by: Mark Cave-Ayland <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>
---
hw/ide/macio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ide/macio.c b/hw/ide/macio.c
index 9771261..d4031b6 100644
--- a/hw/ide/macio.c
+++ b/hw/ide/macio.c
@@ -280,7 +280,7 @@ static void pmac_ide_atapi_transfer_cb(void *opaque, int
ret)
}
/* Calculate current offset */
- offset = (int64_t)(s->lba << 11) + s->io_buffer_index;
+ offset = ((int64_t)s->lba << 11) + s->io_buffer_index;
pmac_dma_read(s->blk, offset, io->len, pmac_ide_atapi_transfer_cb, io);
return;
--
2.4.3
- [Qemu-devel] [PULL v2 00/11] Ide patches, John Snow, 2016/01/11
- [Qemu-devel] [PULL v2 01/11] macio: fix overflow in lba to offset conversion for ATAPI devices,
John Snow <=
- [Qemu-devel] [PULL v2 06/11] libqos/ahci: Switch to mutable properties, John Snow, 2016/01/11
- [Qemu-devel] [PULL v2 05/11] libqos/ahci: ATAPI identify, John Snow, 2016/01/11
- [Qemu-devel] [PULL v2 07/11] libqos: allow zero-size allocations, John Snow, 2016/01/11
- [Qemu-devel] [PULL v2 10/11] qtest/ahci: ATAPI data tests, John Snow, 2016/01/11
- [Qemu-devel] [PULL v2 03/11] ahci-test: fix memory leak, John Snow, 2016/01/11
- [Qemu-devel] [PULL v2 02/11] ide: ahci: reset ncq object to unused on error, John Snow, 2016/01/11
- [Qemu-devel] [PULL v2 04/11] libqos/ahci: ATAPI support, John Snow, 2016/01/11
- [Qemu-devel] [PULL v2 08/11] libqos/ahci: allow nondata commands for ahci_io variants, John Snow, 2016/01/11
- [Qemu-devel] [PULL v2 11/11] libqos/ahci: organize header, John Snow, 2016/01/11
- [Qemu-devel] [PULL v2 09/11] libqos/ahci: add ahci_exec, John Snow, 2016/01/11