[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 08/24] net/vmxnet3: return correct value for VMXNET3_
From: |
Jason Wang |
Subject: |
[Qemu-devel] [PULL 08/24] net/vmxnet3: return correct value for VMXNET3_CMD_GET_DID_* command |
Date: |
Mon, 11 Jan 2016 13:30:59 +0800 |
From: Miao Yan <address@hidden>
VMXNET3_CMD_GET_DID_LO should return PCI ID of the device
and VMXNET3_CMD_GET_DID_HI should return vmxnet3 revision ID.
This behavior can be observed by the following steps:
1) run a Linux distro on esxi server (5.x+)
2) modify vmxnet3 Linux driver to read DID_HI and DID_LO:
VMXNET3_WRITE_BAR1_REG(adapter, VMXNET3_REG_CMD, VMXNET3_CMD_GET_DID_LO);
lo = VMXNET3_READ_BAR1_REG(adapter, VMXNET3_REG_CMD);
VMXNET3_WRITE_BAR1_REG(adapter, VMXNET3_REG_CMD, VMXNET3_CMD_GET_DID_HI);
high = VMXNET3_READ_BAR1_REG(adapter, VMXNET3_REG_CMD);
pr_info("vmxnet3 DID lo: 0x%x, high: 0x%x\n", lo, high);
The kernel log will have something like the following message:
[ 7005.111170] vmxnet3 DID lo: 0x7b0, high: 0x1
Signed-off-by: Miao Yan <address@hidden>
Reviewed-by: Dmitry Fleytman <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
---
hw/net/vmxnet3.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
index 8a992d3..0aff0d4 100644
--- a/hw/net/vmxnet3.c
+++ b/hw/net/vmxnet3.c
@@ -1650,6 +1650,14 @@ static void vmxnet3_handle_command(VMXNET3State *s,
uint64_t cmd)
"adaptive ring info flags");
break;
+ case VMXNET3_CMD_GET_DID_LO:
+ VMW_CBPRN("Set: Get lower part of device ID");
+ break;
+
+ case VMXNET3_CMD_GET_DID_HI:
+ VMW_CBPRN("Set: Get upper part of device ID");
+ break;
+
default:
VMW_CBPRN("Received unknown command: %" PRIx64, cmd);
break;
@@ -1693,6 +1701,14 @@ static uint64_t vmxnet3_get_command_status(VMXNET3State
*s)
ret = VMXNET3_DISABLE_ADAPTIVE_RING;
break;
+ case VMXNET3_CMD_GET_DID_LO:
+ ret = PCI_DEVICE_ID_VMWARE_VMXNET3;
+ break;
+
+ case VMXNET3_CMD_GET_DID_HI:
+ ret = VMXNET3_DEVICE_REVISION;
+ break;
+
default:
VMW_WRPRN("Received request for unknown command: %x", s->last_command);
ret = -1;
--
2.5.0
- [Qemu-devel] [PULL 00/24] Net patches, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 01/24] net/vmxnet3: fix a build error when enabling debug output, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 02/24] net/vmxnet3: use %zu for size_t in printf, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 03/24] net/vmxnet3: fix debug macro pattern for vmxnet3, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 04/24] net/vmxnet3: remove redundant VMW_SHPRN(...) definition, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 05/24] net: vmxnet3: avoid memory leakage in activate_device, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 06/24] MAINTAINERS: Add an entry for the net/slirp.c file, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 07/24] net/vmxnet3: return 1 on device activation failure, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 08/24] net/vmxnet3: return correct value for VMXNET3_CMD_GET_DID_* command,
Jason Wang <=
- [Qemu-devel] [PULL 09/24] net/vmxnet3: return correct value for VMXNET3_CMD_GET_DEV_EXTRA_INFO, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 10/24] net/vmxnet3: return 0 on unknown command, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 11/24] net/vmxnet3: rename VMXNET3_DEVICE_VERSION to VMXNET3_UPT_REVISION, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 12/24] net/dump: fix nfds->filename leak, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 13/24] net/filter: fix nf->netdev_id leak, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 14/24] vmxnet3: Change offsets of msi/msix pci capabilities, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 15/24] vmxnet3: Change the offset of the MSIX PBA table, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 16/24] vmxnet3: Introduce 'x-old-msi-offsets' back-compat property, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 17/24] vmxnet3: coding: Introduce VMXNET3Class, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 18/24] vmxnet3: The vmxnet3 device is a PCIE endpoint, Jason Wang, 2016/01/11