Re: [Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

[Denis V. Lunev]

On 12/24/2015 12:40 AM, Eric Blake wrote:
> On 12/04/2015 07:44 AM, Denis V. Lunev wrote:
> > 'name' attribute is made mandatory in distinction with HMP command.
> >
> > The patch also moves hmp_savevm implementation into hmp.c. This function
> > is just a simple wrapper now and does not have knowledge about
> > migration internals.
> >
> > Signed-off-by: Denis V. Lunev <address@hidden>
> > CC: Juan Quintela <address@hidden>
> > CC: Amit Shah <address@hidden>
> > CC: Markus Armbruster <address@hidden>
> > CC: Eric Blake <address@hidden>
> > ---
> >   hmp.c              | 12 ++++++++++++
> >   migration/savevm.c | 13 +------------
> >   qapi-schema.json   | 13 +++++++++++++
> >   qmp-commands.hx    | 25 +++++++++++++++++++++++++
> >   4 files changed, 51 insertions(+), 12 deletions(-)
> >
> > diff --git a/hmp.c b/hmp.c
> > index 2140605..c9c7100 100644
> > --- a/hmp.c
> > +++ b/hmp.c
> > @@ -32,6 +32,7 @@
> >   #include "ui/console.h"
> >   #include "block/qapi.h"
> >   #include "qemu-io.h"
> > +#include "sysemu/sysemu.h"
> What is this header needed for?
it contains prototype of hmp_savevm. The following warning
appears without it:

irbis ~/src/qemu $ make -j8
  CC    hmp.o
hmp.c:2390:6: error: no previous prototype for ‘hmp_savevm’ 
[-Werror=missing-prototypes]
 void hmp_savevm(Monitor *mon, const QDict *qdict)
      ^
cc1: all warnings being treated as errors
/home/den/src/qemu/rules.mak:57: recipe for target 'hmp.o' failed
make: *** [hmp.o] Error 1
irbis ~/src/qemu $