[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 14/55] ipmi: Add a local BMC simulation
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PULL 14/55] ipmi: Add a local BMC simulation |
Date: |
Fri, 8 Jan 2016 10:02:02 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 22/12/2015 17:53, Michael S. Tsirkin wrote:
> + case IPMI_BMC_WATCHDOG_PRE_NMI:
> + if (!k->do_hw_op(s, IPMI_SEND_NMI, 1)) {
> + /* NMI not supported. */
> + rsp[2] = IPMI_CC_INVALID_DATA_FIELD;
> + goto out;
> + }
> + default:
> + /* We don't support PRE_SMI */
> + rsp[2] = IPMI_CC_INVALID_DATA_FIELD;
> + goto out;
Hi Michael and Corey,
Coverity here complains that the "case IPMI_BMC_WATCHDOG_PRE_NMI" falls
through to the default case. If anything, you could negate the "if"
condition and then it would make sense to fall through; but given how
the code is written, I think Coverity is correct.
Thanks,
Paolo
- [Qemu-devel] [PULL 00/55] acpi, pc features, Michael S. Tsirkin, 2016/01/08
- Message not available
- Re: [Qemu-devel] [PULL 14/55] ipmi: Add a local BMC simulation,
Paolo Bonzini <=
- Message not available
- [Qemu-devel] [PULL 01/55] mmap-alloc: tweak a comment on ppc64, Michael S. Tsirkin, 2016/01/08
- [Qemu-devel] [PULL 03/55] pc: Move legacy_acpi_table_size global to PCMachineClass, Michael S. Tsirkin, 2016/01/08
- [Qemu-devel] [PULL 02/55] pc: Move compat boolean globals to PCMachineClass, Michael S. Tsirkin, 2016/01/08
- Re: [Qemu-devel] [PULL 00/55] acpi, pc features, Peter Maydell, 2016/01/08