[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] compat: Introduce HW_COMPAT_2_5
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] compat: Introduce HW_COMPAT_2_5 |
Date: |
Thu, 7 Jan 2016 17:46:11 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 07/01/2016 17:33, Cornelia Huck wrote:
> On Thu, 7 Jan 2016 17:30:20 +0100
> Paolo Bonzini <address@hidden> wrote:
>
>> On 23/12/2015 20:21, Shmulik Ladkani wrote:
>>> Hi,
>>>
>>> On Fri, 18 Dec 2015 09:30:02 +0200 Shmulik Ladkani <address@hidden> wrote:
>>>> Introduce the place-holder for 2.5 back-compat properties, and the
>>>> accompanying PC_COMPAT_2_5, CCW_COMPAT_2_5, SPAPR_COMPAT_2_5.
>>>
>>> Please ignore this series, it'll clash.
>>>
>>> Recent pull has already introduced HW_COMPAT_2_5 and PC_COMPAT_2_5
>>> (240240d pc: Add pc-*-2.6 machine classes).
>>>
>>> I'll send patches introducing only CCW_COMPAT_2_5 and SPAPR_COMPAT_2_5
>>
>> Can you send these now?
>
> I've already added the CCW_COMPAT_2_5 patch to my queue.
>
Ok, so I can send Shmulik's patch doing
@@ -2,14 +2,7 @@
#define HW_COMPAT_H
#define HW_COMPAT_2_5 \
- /* empty */
-
-#define HW_COMPAT_2_4 \
{\
- .driver = "virtio-blk-device",\
- .property = "scsi",\
- .value = "true",\
- },{\
.driver = "pvscsi",\
.property = "x-old-pci-configuration",\
.value = "on",\
@@ -17,6 +10,13 @@
.driver = "pvscsi",\
.property = "x-disable-pcie",\
.value = "on",\
+ },
+
+#define HW_COMPAT_2_4 \
+ {\
+ .driver = "virtio-blk-device",\
+ .property = "scsi",\
+ .value = "true",\
},{\
.driver = "e1000",\
.property = "extra_mac_registers",\
in my next pull request.
Paolo