[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/34] kvm_stat: Cleanup and fixup
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 00/34] kvm_stat: Cleanup and fixup |
Date: |
Thu, 7 Jan 2016 16:44:10 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 07/01/2016 14:41, Cornelia Huck wrote:
> On Tue, 15 Dec 2015 10:56:35 +0100
> Cornelia Huck <address@hidden> wrote:
>
>> On Thu, 10 Dec 2015 13:12:30 +0100
>> Janosch Frank <address@hidden> wrote:
>>
>>> Kvm_stat is a very helpful script for checking the state of VMs, but
>>> when I tried to introduce new features it broke every few lines.
>>>
>>> This patch series aims to make the script more readable and durable,
>>> so future additions to it will break it less likely. It also fixes
>>> input/output problems for all of its interface modes.
>>>
>>> Testing was done rarely on X86_64 RHEL 6.7 and mostly on s390. Tests
>>> on other architectures would be beneficial.
>>
>> The cleanup and fixes look good to me, but I'm most certainly not a
>> python expert :)
>>
>> Paolo, would you take these through the kvm tree?
>
> Anybody interested in these? I can't really comment on python stuff,
> but it would be a shame if these patches were left out in the cold...
Ok, I've now reviewed it. I didn't have many comments, but the
Signed-off-by was missing so I prefer to have a v2 instead of follow-up
patches.
Paolo