[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 30/35] qapi-visit: Unify struct and union vis
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH v8 30/35] qapi-visit: Unify struct and union visit |
Date: |
Tue, 5 Jan 2016 15:03:52 +0100 |
Hi
On Mon, Dec 21, 2015 at 6:08 PM, Eric Blake <address@hidden> wrote:
> We are finally at the point where gen_visit_struct() and
> gen_visit_union() can be unified to a generic gen_visit_object().
>
> The generated code for structs and for flat unions is unchanged.
> For simple unions, a new visit_type_FOO_fields() is created,
> wrapping the visit of the non-variant tag field:
>
> |+static void visit_type_ChardevBackend_fields(Visitor *v, ChardevBackend
> **obj, Error **errp)
> |+{
> |+ Error *err = NULL;
> |+
> |+ visit_type_ChardevBackendKind(v, "type", &(*obj)->type, &err);
> |+ if (err) {
> |+ goto out;
> |+ }
> |+
> |+out:
> |+ error_propagate(errp, err);
> |+}
> |+
> | void visit_type_ChardevBackend(Visitor *v, const char *name, ChardevBackend
> **obj, Error **errp)
> | {
> | Error *err = NULL;
> |@@ -2319,7 +2332,7 @@ void visit_type_ChardevBackend(Visitor *
> | if (!*obj) {
> | goto out_obj;
> | }
> |- visit_type_ChardevBackendKind(v, "type", &(*obj)->type, &err);
> |+ visit_type_ChardevBackend_fields(v, obj, &err);
> | if (err) {
>
> Signed-off-by: Eric Blake <address@hidden>
>
Reviewed-by: Marc-André Lureau <address@hidden>
--
Marc-André Lureau
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v8 30/35] qapi-visit: Unify struct and union visit,
Marc-André Lureau <=