[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH COLO-Frame v13 38/39] colo: Use default buffer-filte
From: |
zhanghailiang |
Subject: |
[Qemu-devel] [PATCH COLO-Frame v13 38/39] colo: Use default buffer-filter to buffer and release packets |
Date: |
Tue, 29 Dec 2015 15:09:34 +0800 |
Enable default filter to buffer packets and release the
packets after a checkpoint.
Signed-off-by: zhanghailiang <address@hidden>
Cc: Jason Wang <address@hidden>
Cc: Yang Hongyang <address@hidden>
---
v12:
- Add a helper function to check if all netdev supports buffer packets.
- Flush buffered packets when do failover.
v11:
- Use new helper functions to buffer and release packets.
---
include/net/net.h | 1 +
migration/colo.c | 25 ++++++++++++++++++++++++-
net/net.c | 17 +++++++++++++++++
3 files changed, 42 insertions(+), 1 deletion(-)
diff --git a/include/net/net.h b/include/net/net.h
index 5c65c45..2eb9451 100644
--- a/include/net/net.h
+++ b/include/net/net.h
@@ -129,6 +129,7 @@ typedef void (*qemu_netfilter_foreach)(NetFilterState *nf,
void *opaque,
Error **errp);
void qemu_foreach_netfilter(qemu_netfilter_foreach func, void *opaque,
Error **errp);
+bool qemu_netdev_support_netfilter(void);
int qemu_can_send_packet(NetClientState *nc);
ssize_t qemu_sendv_packet(NetClientState *nc, const struct iovec *iov,
int iovcnt);
diff --git a/migration/colo.c b/migration/colo.c
index bd68e86..23e1131 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -18,6 +18,8 @@
#include "qemu/error-report.h"
#include "migration/failover.h"
#include "qapi-event.h"
+#include "net/filter.h"
+#include "net/net.h"
static bool vmstate_loading;
@@ -129,6 +131,11 @@ static void primary_vm_do_failover(void)
old_state);
return;
}
+ /* Don't buffer any packets while exited COLO */
+ qemu_set_default_filters_status(false);
+ /* Flush the residuary buffered packts */
+ qemu_release_default_filters_packets();
+
/* Notify COLO thread that failover work is finished */
qemu_sem_post(&s->colo_sem);
}
@@ -335,6 +342,8 @@ static int colo_do_checkpoint_transaction(MigrationState *s,
goto out;
}
+ qemu_release_default_filters_packets();
+
if (colo_shutdown) {
colo_put_cmd(s->to_dst_file, COLO_COMMAND_GUEST_SHUTDOWN, &local_err);
if (local_err) {
@@ -379,6 +388,17 @@ static int colo_prepare_before_save(MigrationState *s)
return ret;
}
+static int colo_init_buffer_filters(void)
+{
+ if (!qemu_netdev_support_netfilter()) {
+ return -EPERM;
+ }
+ /* Begin to buffer packets that sent by VM */
+ qemu_set_default_filters_status(true);
+
+ return 0;
+}
+
static void colo_process_checkpoint(MigrationState *s)
{
QEMUSizedBuffer *buffer = NULL;
@@ -387,7 +407,10 @@ static void colo_process_checkpoint(MigrationState *s)
int ret;
failover_init_state();
-
+ ret = colo_init_buffer_filters();
+ if (ret < 0) {
+ goto out;
+ }
s->rp_state.from_dst_file = qemu_file_get_return_path(s->to_dst_file);
if (!s->rp_state.from_dst_file) {
error_report("Open QEMUFile from_dst_file failed");
diff --git a/net/net.c b/net/net.c
index 30946c5..4678a6e 100644
--- a/net/net.c
+++ b/net/net.c
@@ -288,6 +288,23 @@ void qemu_foreach_netfilter(qemu_netfilter_foreach func,
void *opaque,
}
}
+bool qemu_netdev_support_netfilter(void)
+{
+ NetClientState *nc;
+
+ QTAILQ_FOREACH(nc, &net_clients, next) {
+ if (nc->info->type == NET_CLIENT_OPTIONS_KIND_NIC) {
+ continue;
+ }
+ if (QTAILQ_EMPTY(&nc->filters)) {
+ error_report("netdev (%s) does not support filter", nc->name);
+ return false;
+ }
+ }
+
+ return true;
+}
+
static void qemu_net_client_destructor(NetClientState *nc)
{
g_free(nc);
--
1.8.3.1
- [Qemu-devel] [PATCH COLO-Frame v13 03/39] COLO: migrate colo related info to secondary node, (continued)
- [Qemu-devel] [PATCH COLO-Frame v13 03/39] COLO: migrate colo related info to secondary node, zhanghailiang, 2015/12/29
- [Qemu-devel] [PATCH COLO-Frame v13 35/39] filter-buffer: Accept zero interval, zhanghailiang, 2015/12/29
- [Qemu-devel] [PATCH COLO-Frame v13 37/39] filter-buffer: Introduce a helper function to release packets, zhanghailiang, 2015/12/29
- [Qemu-devel] [PATCH COLO-Frame v13 21/39] COLO failover: Introduce a new command to trigger a failover, zhanghailiang, 2015/12/29
- [Qemu-devel] [PATCH COLO-Frame v13 26/39] COLO failover: Shutdown related socket fd when do failover, zhanghailiang, 2015/12/29
- [Qemu-devel] [PATCH COLO-Frame v13 25/39] qmp event: Add COLO_EXIT event to notify users while exited from COLO, zhanghailiang, 2015/12/29
- [Qemu-devel] [PATCH COLO-Frame v13 34/39] net/filter-buffer: Add default filter-buffer for each netdev, zhanghailiang, 2015/12/29
- [Qemu-devel] [PATCH COLO-Frame v13 31/39] savevm: Introduce two helper functions for save/find loadvm_handlers entry, zhanghailiang, 2015/12/29
- [Qemu-devel] [PATCH COLO-Frame v13 28/39] COLO: Process shutdown command for VM in COLO state, zhanghailiang, 2015/12/29
- [Qemu-devel] [PATCH COLO-Frame v13 36/39] filter-buffer: Introduce a helper function to enable/disable default filter, zhanghailiang, 2015/12/29
- [Qemu-devel] [PATCH COLO-Frame v13 38/39] colo: Use default buffer-filter to buffer and release packets,
zhanghailiang <=
- [Qemu-devel] [PATCH COLO-Frame v13 06/39] migration: Integrate COLO checkpoint process into migration, zhanghailiang, 2015/12/29
- Re: [Qemu-devel] [PATCH COLO-Frame v13 00/39] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT), Hailiang Zhang, 2015/12/29