[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/7] qemu-img: allow specifying image as a set o
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 7/7] qemu-img: allow specifying image as a set of options args |
Date: |
Wed, 23 Dec 2015 19:03:34 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 23/12/2015 17:55, Daniel P. Berrange wrote:
>>> > > A third option would be to keep using positional arguments, but
>>> > > add a '--source-opts' *boolean* flag to indicate how to interpret
>>> > > the positional arguments. ie without --source-opts we use the
>>> > > historic syntax, but with --source-opts, we assume the full QemuOpts
>>> > > syntax.
>> >
>> > Oh, nice compromise. It's relatively discoverable (grep --help output),
>> > preserves back-compat of old scripts, and offers the full power for
>> > clients that want the full power.
> I've implemented this now and it makes the patches soooo much simpler
> too, so an added win.
Hmm, looks like I'm a bit late, but here's another possibility: making
--source-options (aka -o) take an argument, and if you specify both
--source-options and the positional argument, the latter is added as a
"file" key.
This way you can do "qemu-img info --object secret... -o secret=foo
iscsi://foo/".
Paolo
- [Qemu-devel] [PATCH 2/7] qemu-img: add support for --object command line arg, (continued)
- [Qemu-devel] [PATCH 2/7] qemu-img: add support for --object command line arg, Daniel P. Berrange, 2015/12/22
- [Qemu-devel] [PATCH 7/7] qemu-img: allow specifying image as a set of options args, Daniel P. Berrange, 2015/12/22
- Re: [Qemu-devel] [PATCH 7/7] qemu-img: allow specifying image as a set of options args, Eric Blake, 2015/12/22
- Re: [Qemu-devel] [PATCH 7/7] qemu-img: allow specifying image as a set of options args, Daniel P. Berrange, 2015/12/22
- Re: [Qemu-devel] [PATCH 7/7] qemu-img: allow specifying image as a set of options args, Eric Blake, 2015/12/22
- Re: [Qemu-devel] [PATCH 7/7] qemu-img: allow specifying image as a set of options args, Daniel P. Berrange, 2015/12/22
- Re: [Qemu-devel] [PATCH 7/7] qemu-img: allow specifying image as a set of options args, Eric Blake, 2015/12/22
- Re: [Qemu-devel] [PATCH 7/7] qemu-img: allow specifying image as a set of options args, Daniel P. Berrange, 2015/12/23
- Re: [Qemu-devel] [PATCH 7/7] qemu-img: allow specifying image as a set of options args,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 7/7] qemu-img: allow specifying image as a set of options args, Daniel P. Berrange, 2015/12/23
- Re: [Qemu-devel] [PATCH 7/7] qemu-img: allow specifying image as a set of options args, Paolo Bonzini, 2015/12/23
- Re: [Qemu-devel] [PATCH 7/7] qemu-img: allow specifying image as a set of options args, Daniel P. Berrange, 2015/12/24