Re: [Qemu-devel] [PATCH 08/10] qcow2: Fix BDRV_O_INCOMING handling in qcow2_invalidate_cache()

[Eric Blake]

On 12/22/2015 09:46 AM, Kevin Wolf wrote:
> What qcow2_invalidate_cache() should do is closing the image with
> BDRV_O_INCOMING set and reopening it with the flag cleared. In fact, it

Might read better with s/closing/close/, s/reopening/reopen/

> used to do exactly the opposite: qcow2_close() relied on bs->open_flags,
> which is already updated to have cleared BDRV_O_INCOMING at this point,
> whereas qcow2_open() was called with s->flags, which has the flag still
> set. Fix this.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/qcow2.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature