Re: [Qemu-devel] x-input-send-event marked as experimental

[Marcelo Tosatti]

On Fri, Dec 18, 2015 at 09:01:33PM +0100, Markus Armbruster wrote:
> Marcelo Tosatti <address@hidden> writes:
> 
> > Gerd,
> >
> > commit df5b2adb7398d71016ee469f71e52075ed95e04e
> > Author: Gerd Hoffmann <address@hidden>
> > Date:   Tue Nov 25 14:54:17 2014 +0100
> >
> >     input: move input-send-event into experimental namespace
> >     
> >     Ongoing discussions on how we are going to specify the console,
> >     so tag the command as experiental so we can refine things in
> >     the 2.3 development cycle.
> >
> > So what is the problem here again? 
> > input-send-event can send an input event to a 
> > particular console, so that (the console number)
> > has to be specified somehow.
> >
> > But, its already there, you can specify the console:
> >
> > -{ 'command': 'input-send-event',
> > +{ 'command': 'x-input-send-event',
> >    'data': { '*console':'int', 'events': [ 'InputEvent' ] } }
> >
> > So what its waiting for to be moved out of experimental status?
> 
> See
> 
> * http://lists.gnu.org/archive/html/qemu-devel/2014-11/msg03425.html
>   Message-ID: <address@hidden>
>   and the thread around it

There are multiple points, the reason is not clear to me (i am looking
for the reason why this has been marked as experimental, as there is not
much ambiguity in the meaning of "sending an event to an input device".

Is it because console numbers should not be exposed?

"Begs the question why we're using console numbers in one place (QMP) and
qdev IDs in another (command line).  Why can't we use one of them
everywhere?  Or maybe support both everywhere?"
 
> * http://lists.gnu.org/archive/html/qemu-devel/2015-11/msg02935.html
>   Message-ID: <address@hidden>

"The latter would be consistent with how we are doing input routing,
i.e.
grouping display and input devices to a seat for multiseat setups (see
docs/multiseat.txt for more details).

The consoles are already present in the qom tree
as /backend/console[<index>] nodes, and they have device + head
children.  So qom users can map console=<index> to
display=<id>,head=<nr> and visa versa already.  So from a functionality
point of view it doesn't really matter, it is largely a matter of
taste ..."

> * commit 513e7cd input: Document why x-input-send-event is still
>   experimental

This explains nothing.

-# Note: this command is experimental, and not a stable API.
+# Note: this command is experimental, and not a stable API.  Things that
+# might change before it becomes stable include the spelling of enum
+# values for InputButton and InputAxis, and the notion of how to designate
+# which console will receive the event.
 #

---

Ok, so can't find an actual argument for this 
experimental flag at this point.