[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 07/14] acpi: Remove guest_info parameters fro
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v2 07/14] acpi: Remove guest_info parameters from functions |
Date: |
Fri, 18 Dec 2015 16:08:05 -0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, Dec 15, 2015 at 02:36:10PM +0200, Marcel Apfelbaum wrote:
> On 12/11/2015 08:42 PM, Eduardo Habkost wrote:
> >We can use PC_MACHINE(qdev_get_machine())->acpi_guest_info to get
> >guest_info.
>
> Hi Eduardo,
>
> I like the idea of using qdev_get_machine() to get the machine instead of
> keeping the reference around, however only in places we cannot get a reference
> to it otherwise.
I was unsure if I should go to the extreme of removing all the
guest_info parameters, when doing that. I agree with your
suggestions, but v3 will have to wait until I get back from
vacations in Jan 18th. At least we will have less conflicts with
Igor's AML series. :)
Thanks!
--
Eduardo
- [Qemu-devel] [PATCH v2 03/14] pc: Move PcGuestInfo declaration to top of file, (continued)
- [Qemu-devel] [PATCH v2 03/14] pc: Move PcGuestInfo declaration to top of file, Eduardo Habkost, 2015/12/11
- [Qemu-devel] [PATCH v2 04/14] pc: Eliminate struct PcGuestInfoState, Eduardo Habkost, 2015/12/11
- [Qemu-devel] [PATCH v2 05/14] pc: Simplify pc_memory_init() signature, Eduardo Habkost, 2015/12/11
- [Qemu-devel] [PATCH v2 06/14] pc: Simplify xen_load_linux() signature, Eduardo Habkost, 2015/12/11
- [Qemu-devel] [PATCH v2 07/14] acpi: Remove guest_info parameters from functions, Eduardo Habkost, 2015/12/11
- [Qemu-devel] [PATCH v2 08/14] acpi: Don't save PcGuestInfo on AcpiBuildState, Eduardo Habkost, 2015/12/11
- [Qemu-devel] [PATCH v2 09/14] pc: Remove compat fields from PcGuestInfo, Eduardo Habkost, 2015/12/11
- [Qemu-devel] [PATCH v2 10/14] pc: Remove RAM size fields from PcGuestInfo, Eduardo Habkost, 2015/12/11
- [Qemu-devel] [PATCH v2 11/14] pc: Remove PcGuestInfo.isapc_ram_fw field, Eduardo Habkost, 2015/12/11