[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 21/23] error: Clean up errors with embedded n
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 21/23] error: Clean up errors with embedded newlines (again) |
Date: |
Fri, 18 Dec 2015 11:04:59 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 12/17/2015 09:50 AM, Markus Armbruster wrote:
>> The arguments of error_report() should yield a short error string
>> without newlines.
>>
>> A few places try to print additional help after the error message by
>> embedding newlines in the error string. That's nice, but let's do it
>> the right way. Commit 474c213 cleaned up some, but they keep coming
>> back. Offenders tracked down with the Coccinelle semantic patch from
>> commit 312fd5f.
>
> Not sure if you'll have any stragglers from 1/23 here, after fixing 16/23.
Just one:
qemu-nbd.c:604:28:"Invalid number of argument.\n" "Try `%s --help' for more
information."
>>
>> Cc: Laszlo Ersek <address@hidden>
>> Cc: Pavel Fedin <address@hidden>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> Reviewed-by: Laszlo Ersek <address@hidden>
>> ---
>> hw/i386/pc.c | 4 ++--
>> kvm-all.c | 6 +++---
>> 2 files changed, 5 insertions(+), 5 deletions(-)
>>
>
> Reviewed-by: Eric Blake <address@hidden>
Thanks!
- Re: [Qemu-devel] [PATCH v2 09/23] error: New error_prepend(), error_reportf_err(), (continued)
- [Qemu-devel] [PATCH v2 21/23] error: Clean up errors with embedded newlines (again), Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v2 18/23] vmdk: Clean up "Invalid extent lines" error message, Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v2 22/23] hw/s390x: Rename local variables Error *l_err to just err, Markus Armbruster, 2015/12/17
- Re: [Qemu-devel] [PATCH v2 00/23] Error reporting cleanups and fixes, Cornelia Huck, 2015/12/17