[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 16/23] error: Strip trailing '\n' from error
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 16/23] error: Strip trailing '\n' from error string arguments (again) |
Date: |
Fri, 18 Dec 2015 10:47:30 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 12/17/2015 09:49 AM, Markus Armbruster wrote:
>> Commit 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but they
>> keep coming back. Tracked down with the Coccinelle semantic patch
>> from commit 312fd5f.
>
> Don't forget to rerun this to pick up stragglers exposed by 1/23 :)
Just two:
qemu-nbd.c:574:76:"Shared device number must be greater than 0\n"
qemu-nbd.c:557:61:"socket path must be absolute\n"
>> Signed-off-by: Markus Armbruster <address@hidden>
>> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
>> Acked-by: Cornelia Huck <address@hidden>
>> Acked-by: Bharata B Rao <address@hidden>
>> Acked-by: Fam Zheng <address@hidden>
>
> If you want to add to the list:
> Reviewed-by: Eric Blake <address@hidden>
>
>> +++ b/hw/s390x/s390-skeys.c
>> @@ -191,8 +191,8 @@ static int qemu_s390_skeys_set(S390SKeysState *ss,
>> uint64_t start_gfn,
>> /* Check for uint64 overflow and access beyond end of key data */
>> if (start_gfn + count > skeydev->key_count || start_gfn + count <
>> count) {
>> error_report("Error: Setting storage keys for page beyond the end "
>> - "of memory: gfn=%" PRIx64 " count=%" PRId64 "\n", start_gfn,
>> - count);
>> + "of memory: gfn=%" PRIx64 " count=%" PRId64,
>> + start_gfn, count);
>
> Do we want a separate patch cleaning up 'Error: ' prefixes?
After my Christmas break, in a separate series probably.
- [Qemu-devel] [PATCH v2 00/23] Error reporting cleanups and fixes, Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v2 03/23] error: Use error_report_err() instead of monitor_printf(), Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v2 02/23] error: Use error_report_err() where appropriate (again), Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v2 16/23] error: Strip trailing '\n' from error string arguments (again), Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v2 06/23] block: Clean up "Could not create temporary overlay" error message, Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v2 05/23] error: Improve documentation around error_append_hint(), Markus Armbruster, 2015/12/17
- Re: [Qemu-devel] [PATCH v2 05/23] error: Improve documentation around error_append_hint(), Eric Blake, 2015/12/17
- Re: [Qemu-devel] [PATCH v2 05/23] error: Improve documentation around error_append_hint(), Markus Armbruster, 2015/12/17
- Re: [Qemu-devel] [PATCH v2 05/23] error: Improve documentation around error_append_hint(), Eric Blake, 2015/12/17
- Re: [Qemu-devel] [PATCH v2 05/23] error: Improve documentation around error_append_hint(), Markus Armbruster, 2015/12/17
- Re: [Qemu-devel] [PATCH v2 05/23] error: Improve documentation around error_append_hint(), Eric Blake, 2015/12/17
- Re: [Qemu-devel] [PATCH v2 05/23] error: Improve documentation around error_append_hint(), Markus Armbruster, 2015/12/18
[Qemu-devel] [PATCH v2 07/23] qemu-nbd: Clean up "Failed to load snapshot" error message, Markus Armbruster, 2015/12/17