Re: [Qemu-devel] [PATCH v2 01/23] qemu-nbd: Replace BSDism <err.h> by error_report()

[Eric Blake]

On 12/17/2015 11:52 AM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
> 
>> On 12/17/2015 09:49 AM, Markus Armbruster wrote:
>>> Coccinelle semantic patch
>>>

>>>          case 'k':
>>>              sockpath = optarg;
>>>              if (sockpath[0] != '/') {
>>> -                errx(EXIT_FAILURE, "socket path must be absolute\n");
>>> +                error_report("socket path must be absolute\n");
>>
>> I'm guessing later in the series will kill the trailing newline? If so,
>> then this patch is fine (again, limiting to just coccinelle here).
> 
> It's a mistake-preserving patch :)

As it should be. No-op automatic semantic transformations are easiest to
review when they are really no-op.

> 
> It should be killed in PATCH 21, but isn't, because I forgot to run
> Coccinelle again after rebasing v1 onto the patches new in v2.  I'll fix
> PATCH 21.

> 
> What about:
> 
>     A few of the error messages touched have trailing newlines.  They'll
>     be stripped later in this series.

Works for me.

>> Long source line worth wrapping?
>>
>> Line wraps and commit message improvements seem obvious, so I'm okay
>> with adding:
>> Reviewed-by: Eric Blake <address@hidden>
> 
> Thanks!

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature