Re: [Qemu-devel] [PATCH v2] checkpatch: Detect newlines in error_report and other error functions

[Jason J. Herne]

On 12/14/2015 10:40 AM, Markus Armbruster wrote:
> "Jason J. Herne" <address@hidden> writes:
>
> > On 12/14/2015 07:47 AM, Markus Armbruster wrote:
> > > "Jason J. Herne" <address@hidden> writes:
> > >
> > > > We don't want newlines embedded in error messages. This seems to be a common
> > > > problem with new code so let's try to catch it with checkpatch.
> > > >
> > > > This will not catch cases where newlines are inserted into the middle of an
> > > > existing multi-line statement. But those cases should be rare.
> > > >
> > > > Signed-off-by: Jason J. Herne <address@hidden>
...
> > But I will take a look at this series and see if we can do better :).
>
> Thanks!  If we can't, then I'm for taking this imperfect patch, because
> flagging some of these mistakes is better than flagging none.

I won't get a chance to get back to this before the new year. So feel 
free to push this (unless someone objects) and I'll see what I can do 
about improving it in January.
Happy holidays! :)

--
-- Jason J. Herne (address@hidden)