Re: [Qemu-devel] [PULL v2 0/9] Introduce I/O channels framework

[Peter Maydell]

On 17 December 2015 at 15:40, Daniel P. Berrange <address@hidden> wrote:
> The following changes since commit e5fbe28e5424d26fc2c25d0a7ecb927d3c80d5e8:
>
>   Merge remote-tracking branch 
> 'remotes/pmaydell/tags/pull-target-arm-20151217-1' into staging (2015-12-17 
> 13:38:34 +0000)
>
> are available in the git repository at:
>
>   git://github.com/berrange/qemu tags/pull-io-channel-base-2015-12-17-2
>
> for you to fetch changes up to 65499bafaf39b75c9787ef39fffeb3ff9fe48424:
>
>   io: add QIOChannelBuffer class (2015-12-17 15:28:33 +0000)
>
> ----------------------------------------------------------------
> Merge I/O channels base classes
>
> ----------------------------------------------------------------
> Daniel P. Berrange (9):
>       io: add abstract QIOChannel classes
>       io: add helper module for creating watches on FDs
>       io: add QIOTask class for async operations
>       io: add QIOChannelSocket class
>       io: add QIOChannelFile class
>       io: add QIOChannelTLS class
>       io: add QIOChannelWebsock class
>       io: add QIOChannelCommand class
>       io: add QIOChannelBuffer class

Still fails on OSX I'm afraid:

/Users/pm215/src/qemu-for-merges/io/channel-buffer.c:211:5: warning:
implicit declaration of function 'g_source_set_name' is invalid
 in C99 [-Wimplicit-function-declaration]
    g_source_set_name(source, "QIOChannelBuffer");
    ^

/Users/pm215/src/qemu-for-merges/io/channel-file.c:164:11: warning:
implicit declaration of function 'lseek64' is invalid in C99 [-W
implicit-function-declaration]
    ret = lseek64(fioc->fd, offset, whence);
          ^

/Users/pm215/src/qemu-for-merges/io/channel-watch.c:155:5: warning:
implicit declaration of function 'g_source_set_name' is invalid in C99
[-Wimplicit-function-declaration]
    g_source_set_name(source, "QIOChannelFD");
    ^

/Users/pm215/src/qemu-for-merges/io/channel-websock.c:923:5: warning:
implicit declaration of function 'g_source_set_name' is invalid in C99
[-Wimplicit-function-declaration]
    g_source_set_name(source, "QIOChannelWebsock");
    ^
  CC    iothread.o

(and then the link fails because those functions aren't present).

Glib's g_source_set_name was only introduced in 2.26,
and we have to support 2.22.

lseek64 doesn't exist on OSX.

thanks
-- PMM