[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 08/13] sysbus: Don't use hw_error() in machin
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v2 08/13] sysbus: Don't use hw_error() in machine_init_done_notifiers |
Date: |
Thu, 17 Dec 2015 15:33:54 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 17/12/15 13:19, Markus Armbruster wrote:
> platform_bus_map_irq() and platform_bus_map_mmio() use hw_error() to
> fail. They run in machine_init_done_notifiers, via
> platform_bus_init_notify() and link_sysbus_device(). Printing CPU
> registers is not helpful there.
>
> Replace hw_error() by error_report(); exit(1). If these are
> programming errors, it should be replaced by an assertion instead.
>
> While there, observe that both functions always return 0, and
> link_sysbus_device() ignores the return value. Change them to void.
>
> Cc: Alexander Graf <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> hw/core/platform-bus.c | 25 ++++++++++++-------------
> 1 file changed, 12 insertions(+), 13 deletions(-)
Reviewed-by: Thomas Huth <address@hidden>
- Re: [Qemu-devel] [PATCH v2 02/13] omap: Don't use hw_error() in device init() methods, (continued)
- [Qemu-devel] [PATCH v2 10/13] isa: Clean up error handling around isa_bus_new(), Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v2 08/13] sysbus: Don't use hw_error() in machine_init_done_notifiers, Markus Armbruster, 2015/12/17
- Re: [Qemu-devel] [PATCH v2 08/13] sysbus: Don't use hw_error() in machine_init_done_notifiers,
Thomas Huth <=
- [Qemu-devel] [PATCH v2 13/13] xen-hvm: Mark inappropriate error handling FIXME, Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v2 03/13] arm_mptimer: Don't use hw_error() in realize() method, Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v2 01/13] hw: Don't use hw_error() for machine initialization errors, Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v2 07/13] hw/arm/virt: Fix property "gic-version" error handling, Markus Armbruster, 2015/12/17