[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/8] bcm2835_ic: add bcm2835 interrupt controlle
From: |
Andrew Baumann |
Subject: |
Re: [Qemu-devel] [PATCH 3/8] bcm2835_ic: add bcm2835 interrupt controller |
Date: |
Wed, 9 Dec 2015 06:25:16 +0000 |
Peter,
Thanks for the feedback on this patch. I agree with all of it, but I do have
one minor quibble...
> From: Peter Crosthwaite [mailto:address@hidden
> Sent: Saturday, 5 December 2015 21:20
> On Thu, Dec 3, 2015 at 10:01 PM, Andrew Baumann
> <address@hidden> wrote:
> > --- a/hw/intc/Makefile.objs
> > +++ b/hw/intc/Makefile.objs
> > @@ -24,6 +24,7 @@ obj-$(CONFIG_GRLIB) += grlib_irqmp.o
> > obj-$(CONFIG_IOAPIC) += ioapic.o
> > obj-$(CONFIG_OMAP) += omap_intc.o
> > obj-$(CONFIG_OPENPIC_KVM) += openpic_kvm.o
> > +obj-$(CONFIG_RASPI) += bcm2835_ic.o
>
> We are trying to encourage -'s for the separators in new file names,
> although admittedly is does seem that intc/ is lagging here.
Sigh. I can rename all the new files if you insist, but what's the rationale
for this?
Just for the record:
% find qemu -iname *.[ch] | grep -c -
1728
% find qemu -iname *.[ch] | grep -c _
1166
Andrew
- [Qemu-devel] [PATCH 0/8] Raspberry Pi 2 support, Andrew Baumann, 2015/12/03
- Re: [Qemu-devel] [PATCH 0/8] Raspberry Pi 2 support, Andrew Baumann, 2015/12/03
- [Qemu-devel] [PATCH 1/8] bcm2835_sbm: add BCM2835 mailboxes, Andrew Baumann, 2015/12/04
- [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller, Andrew Baumann, 2015/12/04
- Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller, Peter Crosthwaite, 2015/12/06
- Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller, Andrew Baumann, 2015/12/09
- Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller, Peter Crosthwaite, 2015/12/09
- Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller, Andrew Baumann, 2015/12/09
- Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller, Peter Crosthwaite, 2015/12/09
- Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller, Andrew Baumann, 2015/12/09
- Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller, Peter Maydell, 2015/12/09
- Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller, Andrew Baumann, 2015/12/09
- Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller, Peter Crosthwaite, 2015/12/09