[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.5 0/2] tests: A cleanup and a fix
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH for-2.5 0/2] tests: A cleanup and a fix |
Date: |
Thu, 03 Dec 2015 13:06:13 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Peter Maydell <address@hidden> writes:
> On 2 December 2015 at 20:20, Markus Armbruster <address@hidden> wrote:
>> PATCH 1 cleans up unnecessary type punning.
>>
>> PATCH 2 plugs a massive memory leak in qom-test. I think it would be
>> nice to have in 2.5, but at this late stage, it's really up to the
>> maintainer.
>
> To go into 2.5 it needs to be reviewed and either be in a pull
> request or have a request from the maintainer for me to apply it
> directly by the end of today UK time.
Understood.
> Is the memory leak a regression, or have we always leaked and
> not noticed?
As far as I can see, a minor leak was introduced in commit 5c1904f, but
the major leakage comes from commit dc06cbd, both v2.0.