[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] block: Fix assertion failure with before wr
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] block: Fix assertion failure with before write notifier again |
Date: |
Thu, 3 Dec 2015 14:50:48 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Tue, Dec 01, 2015 at 05:36:27PM +0800, Fam Zheng wrote:
> This is basically a supplementary fix of 06c3916b.
>
> On 512 disks, the crash only happens when copy-on-read is enabled, which is
> covered by the previou fix. But on 4k disks the write request that triggers
> the notifier itself may be serialised, in which case the read req from
> backup_do_cow will still be serialised in bdrv_aligned_preadv, resulting in
> the
> same assertion failure.
>
> Fam Zheng (3):
> block: Don't wait serialising for non-COR read requests
> iotests: Add "add_drive_raw" method
> iotests: Add regresion test case for write notifier assertion failure
>
> block/backup.c | 2 +-
> block/io.c | 12 +++++++-----
> include/block/block.h | 4 ++--
> tests/qemu-iotests/056 | 25 +++++++++++++++++++++++++
> tests/qemu-iotests/056.out | 4 ++--
> tests/qemu-iotests/iotests.py | 5 +++++
> trace-events | 2 +-
> 7 files changed, 43 insertions(+), 11 deletions(-)
>
> --
> 2.4.3
>
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
signature.asc
Description: PGP signature