[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/9] drivers/hv: replace enum hv_message_type
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/9] drivers/hv: replace enum hv_message_type by u32 |
Date: |
Wed, 2 Dec 2015 13:22:42 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 30/11/2015 17:22, Andrey Smetanin wrote:
> enum hv_message_type inside struct hv_message, hv_post_message
> is not size portable. Replace enum by u32.
It's only non-portable inside structs. Okay to apply just these:
@@ -172,7 +174,7 @@ union hv_message_flags {
/* Define synthetic interrupt controller message header. */
struct hv_message_header {
- u32 message_type;
+ enum hv_message_type message_type;
u8 payload_size;
union hv_message_flags message_flags;
u8 reserved[2];
@@ -345,7 +347,7 @@ enum hv_call_code {
struct hv_input_post_message {
union hv_connection_id connectionid;
u32 reserved;
- u32 message_type;
+ enum hv_message_type message_type;
u32 payload_size;
u64 payload[HV_MESSAGE_PAYLOAD_QWORD_COUNT];
};
?
Paolo
- Re: [Qemu-devel] [PATCH v2 1/9] drivers/hv: replace enum hv_message_type by u32,
Paolo Bonzini <=