[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 09/11] DumpState: adding total_size and writt
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v4 09/11] DumpState: adding total_size and written_size fields |
Date: |
Wed, 2 Dec 2015 17:49:18 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, 12/02 16:49, Peter Xu wrote:
> On Wed, Dec 02, 2015 at 09:32:57AM +0800, Fam Zheng wrote:
> > > @@ -1301,6 +1303,7 @@ static void write_dump_pages(DumpState *s, Error
> > > **errp)
> > > goto out;
> > > }
> > > }
> > > + s->written_size += TARGET_PAGE_SIZE;
> >
> > The same question applies here.
>
> For kdump case, it is using "goto out" when error happens. So it
> seems to have no problem here?
write_cache can fail after you increment it here, no?
Fam
- Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED, (continued)
- Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED, Fam Zheng, 2015/12/01
- Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED, Eric Blake, 2015/12/02
- Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED, Peter Xu, 2015/12/02
- Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED, Eric Blake, 2015/12/02
- Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED, Peter Xu, 2015/12/02
[Qemu-devel] [PATCH v4 09/11] DumpState: adding total_size and written_size fields, Peter Xu, 2015/12/01
[Qemu-devel] [PATCH v4 10/11] Dump: add qmp command "query-dump", Peter Xu, 2015/12/01
[Qemu-devel] [PATCH v4 11/11] Dump: add hmp command "info dump", Peter Xu, 2015/12/01