[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 01/11] dump-guest-memory: cleanup: removing d
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v4 01/11] dump-guest-memory: cleanup: removing dump_{error|cleanup}(). |
Date: |
Wed, 2 Dec 2015 10:50:00 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Dec 02, 2015 at 08:37:36AM +0800, Fam Zheng wrote:
> On Tue, 12/01 21:28, Peter Xu wrote:
> > It might be a little bit confusing to do dump_cleanup() in these two
> > functions and error prone. A better way is to do dump_cleanup()
>
> I would say "It might be a little bit confusing and error prone to do
> dump_cleanup() in ..."
Yes. Changing it.
Thanks.
Peter
>
> Other than that,
>
> Reviewed-by: Fam Zheng <address@hidden>
>
> > before dump finish, no matter whether dump has succeeded or not.
> >
> > Signed-off-by: Peter Xu <address@hidden>
- [Qemu-devel] [PATCH v4 00/11] Add basic "detach" support for dump-guest-memory, Peter Xu, 2015/12/01
- [Qemu-devel] [PATCH v4 01/11] dump-guest-memory: cleanup: removing dump_{error|cleanup}()., Peter Xu, 2015/12/01
- [Qemu-devel] [PATCH v4 02/11] dump-guest-memory: add "detach" flag for QMP/HMP interfaces., Peter Xu, 2015/12/01
- [Qemu-devel] [PATCH v4 03/11] dump-guest-memory: using static DumpState, add DumpStatus, Peter Xu, 2015/12/01
- [Qemu-devel] [PATCH v4 04/11] dump-guest-memory: add dump_in_progress() helper function, Peter Xu, 2015/12/01
- [Qemu-devel] [PATCH v4 05/11] dump-guest-memory: introduce dump_process() helper function., Peter Xu, 2015/12/01
- [Qemu-devel] [PATCH v4 06/11] dump-guest-memory: disable dump when in INMIGRATE state, Peter Xu, 2015/12/01