[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/8] hw/arm/virt-acpi-build: Add power button
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v3 3/8] hw/arm/virt-acpi-build: Add power button device in ACPI DSDT table |
Date: |
Tue, 1 Dec 2015 14:05:32 +0100 |
On Tue, 1 Dec 2015 20:43:36 +0800
Shannon Zhao <address@hidden> wrote:
> Hi Igor,
>
> On 2015/12/1 19:41, Igor Mammedov wrote:
> > On Mon, 16 Nov 2015 21:23:04 +0800
> > address@hidden wrote:
> >
> >> > From: Shannon Zhao <address@hidden>
> >> >
> >> > Add power button device in ACPI DSDT table.
> >> >
> >> > Signed-off-by: Shannon Zhao <address@hidden>
> >> > Signed-off-by: Shannon Zhao <address@hidden>
> >> > Reviewed-by: Wei Huang <address@hidden>
> >> > Tested-by: Wei Huang <address@hidden>
> >> > ---
> >> > hw/arm/virt-acpi-build.c | 13 +++++++++++++
> >> > 1 file changed, 13 insertions(+)
> >> >
> >> > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> >> > index bf6b934..b25c90b 100644
> >> > --- a/hw/arm/virt-acpi-build.c
> >> > +++ b/hw/arm/virt-acpi-build.c
> >> > @@ -340,6 +340,18 @@ static void acpi_dsdt_add_gpio(Aml *scope, const
> >> > MemMapEntry *gpio_memmap,
> >> > aml_append(scope, dev);
> >> > }
> >> >
> >> > +static void acpi_dsdt_add_power_button(Aml *scope)
> >> > +{
> >> > + Aml *dev = aml_device("PWRB");
> >> > + aml_append(dev, aml_name_decl("_HID", aml_string("PNP0C0C")));
> >> > + aml_append(dev, aml_name_decl("_ADR", aml_int(0)));
> >> > + aml_append(dev, aml_name_decl("_UID", aml_int(0)));
> >> > + Aml *method = aml_method("_STA", 0);
> >> > + aml_append(method, aml_return(aml_int(0x0F)));
> >> > + aml_append(dev, method);
> > since _STA always returns 0xF you can just drop it altogether,
> > as _STA == 0xF is implied if it's not present.
> >
>
> Yes, but I think adding this is harmless and make the return value explicit.
It's useless and consumes several bytes, it's better to drop it unless you have
to have it.
> Thanks,