[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 20/21] qemu-iotests: Test cache mode option i
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v2 20/21] qemu-iotests: Test cache mode option inheritance |
Date: |
Mon, 30 Nov 2015 11:32:04 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 27.11.2015 um 22:12 hat Max Reitz geschrieben:
> On 23.11.2015 16:59, Kevin Wolf wrote:
> > This is doing a more complete test on setting cache modes both while
> > opening an image (i.e. in a -drive command line) and in reopen
> > situations. It checks that reopen can specify options for child nodes
> > and that cache modes are correctly inherited from parent nodes where
> > they are not specified.
> >
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
> > tests/qemu-iotests/142 | 354 ++++++++++++++++++++
> > tests/qemu-iotests/142.out | 788
> > +++++++++++++++++++++++++++++++++++++++++++++
> > tests/qemu-iotests/group | 1 +
> > 3 files changed, 1143 insertions(+)
> > create mode 100755 tests/qemu-iotests/142
> > create mode 100644 tests/qemu-iotests/142.out
>
> Comments below, to make it short: With %s/bs->backing_hd/bs->backing/
> and a comment about why you commented 'out | grep "Cache"':
Because I'm stupid. I'll fix that, thanks.
Kevin
pgp1v3iMzQOIZ.pgp
Description: PGP signature
- Re: [Qemu-devel] [PATCH v2 17/21] block: Move cache options into options QDict, (continued)
- [Qemu-devel] [PATCH v2 04/21] block: Allow references for backing files, Kevin Wolf, 2015/11/23
- [Qemu-devel] [PATCH v2 18/21] blkdebug: Enable reopen, Kevin Wolf, 2015/11/23
- [Qemu-devel] [PATCH v2 19/21] qemu-iotests: Try setting cache mode for children, Kevin Wolf, 2015/11/23
- [Qemu-devel] [PATCH v2 21/21] qemu-iotests: Test reopen with node-name/driver options, Kevin Wolf, 2015/11/23
- [Qemu-devel] [PATCH v2 20/21] qemu-iotests: Test cache mode option inheritance, Kevin Wolf, 2015/11/23