[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V3 0/3] hw/pcie: Multi-root support for Q35
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH V3 0/3] hw/pcie: Multi-root support for Q35 |
Date: |
Mon, 30 Nov 2015 06:23:33 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/29/15 13:37, Marcel Apfelbaum wrote:
> On 11/26/2015 07:01 PM, Laszlo Ersek wrote:
>> Hello Marcel,
>>
>
> [...] if you have ACPI table dumps from within an i440fx
>> SeaBIOS Linux guest, both from before and after your QEMU patches, and
>> those dumps are identical, then that's good evidence against
>> regressions. (I tend to do such acpidump-based comparisons when messing
>> with ACPI builder code.)
>>
>
> Hi,
>
> OK, there are no functional differences between the SSDT before/after,
> however the optimization made in patch "1/3 hw/acpi: merge pxb adjacent
> memory/IO ranges"
> for pxb-pcies works also for pxb, which is a good thing.
>
> SSDT before (only PXB differences) :
> -----------------------------------
>
> Device (PC0A)
> {
> ...
> Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
> {
> ...
> DWordMemory (ResourceProducer, PosDecode, MinFixed,
> MaxFixed, NonCacheable, ReadWrite,
> 0x00000000, // Granularity
> 0xFE800000, // Range Minimum
> 0xFE9FFFFF, // Range Maximum
> 0x00000000, // Translation Offset
> 0x00200000, // Length
> ,, , AddressRangeMemory, TypeStatic)
> DWordMemory (ResourceProducer, PosDecode, MinFixed,
> MaxFixed, NonCacheable, ReadWrite,
> 0x00000000, // Granularity
> 0xFE000000, // Range Minimum
> 0xFE7FFFFF, // Range Maximum
> 0x00000000, // Translation Offset
> 0x00800000, // Length
> ,, , AddressRangeMemory, TypeStatic)
> ...
> })
> }
>
> SSDT after:
> ------------
>
> Device (PC0A)
> {
> ...
> Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
> {
> ...
> DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
> NonCacheable, ReadWrite,
> 0x00000000, // Granularity
> 0xFE000000, // Range Minimum
> 0xFE9FFFFF, // Range Maximum
> 0x00000000, // Translation Offset
> 0x00A00000, // Length
> ,, , AddressRangeMemory, TypeStatic)
> ...
> })
> }
>
> As it can be seen, the optimization works also for PXB by merging the
> MEM regions.
>
> Thanks,
> Marcel
>
> [...]
Looks good and makes sense, thanks.
Laszlo
- [Qemu-devel] [PATCH V3 1/3] hw/acpi: merge pxb adjacent memory/IO ranges, (continued)
- [Qemu-devel] [PATCH V3 1/3] hw/acpi: merge pxb adjacent memory/IO ranges, Marcel Apfelbaum, 2015/11/26
- [Qemu-devel] [PATCH V3 2/3] hw/pxb: introduce pxb-pcie expander for PCIe machines, Marcel Apfelbaum, 2015/11/26
- [Qemu-devel] [PATCH V3 3/3] hw/i386: extend pxb query for all PC machines, Marcel Apfelbaum, 2015/11/26
- Re: [Qemu-devel] [PATCH V3 0/3] hw/pcie: Multi-root support for Q35, Laszlo Ersek, 2015/11/26
- Re: [Qemu-devel] [PATCH V3 0/3] hw/pcie: Multi-root support for Q35, Marcel Apfelbaum, 2015/11/29
- Re: [Qemu-devel] [PATCH V3 0/3] hw/pcie: Multi-root support for Q35,
Laszlo Ersek <=