[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 01/21] qcow2: Add .bdrv_join_options callback
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v2 01/21] qcow2: Add .bdrv_join_options callback |
Date: |
Fri, 27 Nov 2015 17:51:56 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 23.11.2015 16:59, Kevin Wolf wrote:
> qcow2 accepts a few driver-specific options that overlap semantically
> (e.g. "overlap-check" is an alias of "overlap-check.template", and any
> missing cache size option is derived from the given ones).
>
> When bdrv_reopen() merges the set of updated options with left out
> options that should be kept at their old value, we need to consider this
> and filter out any duplicates (which would generally cause errors
> because new and old value would contradict each other).
>
> This patch adds a .bdrv_join_options callback to BlockDriver and
> implements it for qcow2.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/qcow2.c | 47
> +++++++++++++++++++++++++++++++++++++++++++++++
> include/block/block_int.h | 1 +
> 2 files changed, 48 insertions(+)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 10/21] block: reopen: Document option precedence and refactor accordingly, (continued)
- [Qemu-devel] [PATCH v2 10/21] block: reopen: Document option precedence and refactor accordingly, Kevin Wolf, 2015/11/23
- [Qemu-devel] [PATCH v2 14/21] blockdev: Set 'format' indicates non-empty drive, Kevin Wolf, 2015/11/23
- [Qemu-devel] [PATCH v2 12/21] block: Split out parse_json_protocol(), Kevin Wolf, 2015/11/23
- [Qemu-devel] [PATCH v2 09/21] block: Allow specifying child options in reopen, Kevin Wolf, 2015/11/23
- [Qemu-devel] [PATCH v2 13/21] block: Introduce bs->explicit_options, Kevin Wolf, 2015/11/23
- [Qemu-devel] [PATCH v2 01/21] qcow2: Add .bdrv_join_options callback, Kevin Wolf, 2015/11/23
- [Qemu-devel] [PATCH v2 15/21] qemu-iotests: Remove cache mode test without medium, Kevin Wolf, 2015/11/23
- [Qemu-devel] [PATCH v2 16/21] block: reopen: Extract QemuOpts for generic block layer options, Kevin Wolf, 2015/11/23
- [Qemu-devel] [PATCH v2 11/21] block: Add infrastructure for option inheritance, Kevin Wolf, 2015/11/23
- [Qemu-devel] [PATCH v2 17/21] block: Move cache options into options QDict, Kevin Wolf, 2015/11/23
- [Qemu-devel] [PATCH v2 04/21] block: Allow references for backing files, Kevin Wolf, 2015/11/23