[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 5/8] dump-query: add "dump-query" command to
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 5/8] dump-query: add "dump-query" command to query dump status |
|
Date: |
Fri, 27 Nov 2015 11:17:52 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 27/11/2015 08:03, Peter Xu wrote:
> > > +{ 'struct': 'DumpStatus',
> > > + 'data': { 'status': 'str', 'percentage': 'str' } }
> >
> > I suggest using enum for "status" and int for "percentage" (or two ints for
> > "total" and "current").
>
> Yes, I picked string just for flexibility. Regarding to this
> interface issue, I'd like to wait for others' comments too before
> modification.
I like Fam's idea of using an enum and two ints.
Also, the command should be named query-dump and the corresponding HMP
command should be "info dump" (by defining "dump" in hmp-commands-info.h".
Paolo
[Qemu-devel] [PATCH v2 6/8] dump-query: implement "status" of "dump-query" command., Peter Xu, 2015/11/26
[Qemu-devel] [PATCH v2 7/8] DumpState: adding total_size and written_size fields, Peter Xu, 2015/11/26
[Qemu-devel] [PATCH v2 8/8] dump-query: make the percentage accurate., Peter Xu, 2015/11/26
Re: [Qemu-devel] [PATCH v2 0/8] Add basic "detach" support for dump-guest-memory, Peter Xu, 2015/11/26