[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/8] dump-guest-memory: cleanup: removing dum
|
From: |
Peter Xu |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/8] dump-guest-memory: cleanup: removing dump_{error|cleanup}(). |
|
Date: |
Fri, 27 Nov 2015 14:51:11 +0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/27/2015 12:28 PM, Fam Zheng wrote:
> I think when write_dump_header() returns a failure, it does call
> dump_cleanup(), in create_header{32,64}.
>
> But the changes of code in this patch look sane to me, and the new error
> handling is definitely looking better.
Yes, you are right. I will modify the commit message to correct
mentioning about memory leak, and keep the codes itself.
Thanks.
Peter
>
> Fam