Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: Prevent activation clicks from going to guest

[Peter Maydell]

On 26 November 2015 at 14:40, Programmingkid <address@hidden> wrote:
>
> On Nov 26, 2015, at 6:45 AM, Peter Maydell wrote:
>
>> On 26 November 2015 at 01:14, Programmingkid <address@hidden> wrote:
>>> When QEMU is brought to the foreground, the click event that activates QEMU
>>> should not go to the guest. Accidents happen when they do go to the guest
>>> without giving the user a change to handle them. Buttons are clicked 
>>> accidently.
>>> Windows are closed accidently. Volumes are unmounted accidently. This patch
>>> prevents these accidents from happening.
>>>
>>> Signed-off-by: John Arbuckle <address@hidden>
>>>
>>> ---
>>> Added code that handles the right mouse button and the other mouse button.
>>
>> This seems like a fair bit of repeated code. Does the change
>> below do the right thing?
> YES! Excellent job with this one. It's very compact.
>
>> I think it ought to work but I don't have
>> any guests handy which use the mouse to check with.
>
> Really?

All of my test guests on the OSX box are serial-console only
(they're faster to boot, and I don't do much development on
OSX anyway.)

> Reviewed-by: John Arbuckle <address@hidden>

Great, thanks for testing this. I'll send it out as a proper
patch with my sign-off and your reviewed-by tag this afternoon.

-- PMM