Re: [Qemu-devel] [PATCH v2 2/4] qemu-iotests: s390x: fix test 051

[tu bo]

Hi Max:

On 11/25/2015 11:41 PM, Max Reitz wrote:
> On 24.11.2015 22:17, Sascha Silbe wrote:
> > This PC/s390x-only hunk looks like an oversight to me.
>
> Not really, see
> http://lists.nongnu.org/archive/html/qemu-devel/2015-02/msg01906.html
> and
> http://lists.nongnu.org/archive/html/qemu-devel/2015-04/msg02851.html
>
> I noticed, but I am fine with it since the tests probably won't run on
> anything but x86/pc and s390 anyway (without modifications; most of the
> changes this series is making to make the iotests work on s390 are
> necessary for other non-pc platforms as well, and that shows to me that
> apparently nobody tried to run the iotests on non-pc platforms before
> s390, or didn't care enough about them to fix them).
>
> >                                                         We should make
> > one of the options the default. I'd prefer defaulting to virtio (see
> > below), but since the test previously hard-coded IDE that would be fine,
> > too.
>
> In my first reply above, I noted that virtio0 may not be available on
> all platforms either. Therefore, I'd rather have an explicit list of
> platforms there than an asterisk where it does not belong.
>
> However, my second reply above spawned a bit of a discussion, where
> Kevin simply proposed to change the ID of the drive to something known,
> i.e. just set the ID by adding an id=drive0 or something to the -drive
> parameter.
>
> Thanks for reminding me of the above, I had already forgotten. Indeed,
> we should just add id=drive0 to the -drive parameter and use drive0. A
> similar solution may be possible in most other places as well where PC
> and s390 differ due to the names of the default devices available.

thanks for the reminder :-)

Yes, Kevin mentioned that we can use "id=testdisk" because it's the same 
on all platforms. Please refer this link:
http://lists.nongnu.org/archive/html/qemu-devel/2015-04/msg03715.html

For test 130, I used "qemu -drive id=testdisk" for both pc and s390x.
For test 051, I didn't find a way to do the same thing for qemu-io.