Re: [Qemu-devel] [PATCH for-2.5] Avoid memory leak

[Markus Armbruster]

stefano <address@hidden> writes:

> On 2015/11/26 11:43, Eric Blake wrote:
>> On 11/25/2015 06:30 PM, dongxingshui wrote:
>>> monitor.c: Avoid memory leak
>>>
>>> When send a wrong qmp command, a memory leak occurs. Fix it.
>> 
>> Looks like the leak was introduced in 710aec9; would be worth amending
>> the commit message to mention that.
>
> Sorry! I didn't see the mailing list before. It has been fixed by Markus.
>
>> 
>> Reviewed-by: Eric Blake <address@hidden>
>> 
>>>
>>> Signed-off-by: dongxingshui <address@hidden>
>> 
>> This looks like your first patch to qemu (at least I wasn't able to find
>> anything from you via 'git log') - welcome to the community.  I suspect
>> that 'dongxingshui' is probably your login name; it doesn't give a
>> Western reader like me an idea where to break into family and personal
>> names.  It's a bit nicer to use a 'Full Name' notation, or even to list
>> your name in two forms (Latin and native UTF-8 characters); see this
>> recent conversation:
>
> I'm pleased to join the community.
> Thank you for your suggestion, i'll change my signed-off message and
> use the following one.
> Signed-off-by: Stefano Dong (董兴水) <address@hidden>

Looks good.  Welcome!