[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 01/14] block: Add "file" output parameter to
|
From: |
Fam Zheng |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 01/14] block: Add "file" output parameter to block status query functions |
|
Date: |
Thu, 26 Nov 2015 13:53:23 +0800 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, 11/25 22:03, Eric Blake wrote:
> On 11/25/2015 12:39 AM, Fam Zheng wrote:
> > The added parameter can be used to return the BDS pointer which the
> > valid offset is referring to. It's value should be ignored unless
>
> s/It's/Its/ (remember, "It's" is valid only if "It is" also works in
> the same place)
Right, it's just easy to typo. Thanks :)
Fam
>
> > BDRV_BLOCK_OFFSET_VALID in ret is set.
> >
> > Until block drivers fill in the right value, let's clear it explicitly
> > right before calling .bdrv_get_block_status.
> >
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
>
> With that fix,
> Reviewed-by: Eric Blake <address@hidden>
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
- [Qemu-devel] [PATCH v2 00/14] qemu-img map: Allow driver to return file of the allocated block, Fam Zheng, 2015/11/25
- [Qemu-devel] [PATCH v2 01/14] block: Add "file" output parameter to block status query functions, Fam Zheng, 2015/11/25
- [Qemu-devel] [PATCH v2 03/14] qcow2: Assign bs->file->bs to file in qcow2_co_get_block_status, Fam Zheng, 2015/11/25
- [Qemu-devel] [PATCH v2 02/14] qcow: Assign bs->file->bs to file in qcow_co_get_block_status, Fam Zheng, 2015/11/25
- [Qemu-devel] [PATCH v2 04/14] raw: Assign bs to file in raw_co_get_block_status, Fam Zheng, 2015/11/25
- [Qemu-devel] [PATCH v2 05/14] iscsi: Assign bs to file in iscsi_co_get_block_status, Fam Zheng, 2015/11/25
- [Qemu-devel] [PATCH v2 06/14] parallels: Assign bs->file->bs to file in parallels_co_get_block_status, Fam Zheng, 2015/11/25
- [Qemu-devel] [PATCH v2 07/14] qed: Assign bs->file->bs to file in bdrv_qed_co_get_block_status, Fam Zheng, 2015/11/25
- [Qemu-devel] [PATCH v2 08/14] sheepdog: Assign bs to file in sd_co_get_block_status, Fam Zheng, 2015/11/25