[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory |
Date: |
Tue, 24 Nov 2015 21:08:29 +0000 |
On 24 November 2015 at 20:52, Andrew Jones <address@hidden> wrote:
>
> I've pulled a v2 together that I'll be testing and posting soon. Here's
> what I decided to do
>
> 1) Throw the fp registers in. Why not?
> 2) No linux-headers update, as we'd also need
> include/uapi/linux/elfcore.h and arch/arm/include/asm/user.h.
> However I've added comments stating where the structs come from.
> 3) Base the vmcore type on the guest kernel, i.e. use arm_el_is_aa64()
> and (env->cp15.sctlr_el[1] & SCTLR_EE). However,
> aarch64_write_elf64_note() will shoehorn 32-bit state into 64-bit
> elf notes when the current state is 32-bit. Those analyzing the
> dumps will need to look at the captured pstate to determine the
> endianness of the registers.
Not sure what you have in mind by "endianness of the registers" --
typically registers aren't thought of as having endianness.
Also, if we're currently executing a 32-bit guest when we take
the core dump, you probably need to call aarch64_sync_32_to_64()
somewhere.
thanks
-- PMM
- Re: [Qemu-devel] [PATCH 1/5] qapi-schema: dump-guest-memory: Improve text, (continued)
- [Qemu-devel] [PATCH 2/5] dump: qemunotes aren't commonly needed, Andrew Jones, 2015/11/19
- [Qemu-devel] [PATCH 4/5] dump: allow target to set the physical base, Andrew Jones, 2015/11/19
- [Qemu-devel] [PATCH 3/5] dump: allow target to set the page size, Andrew Jones, 2015/11/19
- [Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory, Andrew Jones, 2015/11/19
- Re: [Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory, Peter Maydell, 2015/11/20
- Re: [Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory, Andrew Jones, 2015/11/20
- Re: [Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory, Andrew Jones, 2015/11/21
- Re: [Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory, Andrew Jones, 2015/11/24
- Re: [Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory, Andrew Jones, 2015/11/24
- Re: [Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory, Peter Maydell, 2015/11/24