[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 09/10] trace: [tcg] Add per-vCPU tracing stat
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 09/10] trace: [tcg] Add per-vCPU tracing states for events with the 'vcpu' property |
Date: |
Tue, 24 Nov 2015 10:57:05 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/24/2015 10:09 AM, Lluís Vilanova wrote:
> Each event with the 'vcpu' property gets a per-vCPU dynamic tracing state.
>
> The set of enabled events with the 'vcpu' and 'tcg' properties is used
> to select a per-vCPU physical TB cache. The number of events with both
> properties is used to select the number of physical TB caches, and a
> bitmap of the identifiers of such enabled events is used to select a
> physical TB cache.
>
> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
> +++ b/qapi/trace.json
> @@ -29,7 +29,7 @@
> #
> # @name: Event name.
> # @state: Tracing state.
> -# @vcpu: Whether this is a per-vCPU event (since 2.5).
> +# @vcpu: #optional Whether this is a per-vCPU event (since 2.5).
> #
> # Since 2.2
> ##
Spurious hunk? It looks like vcpu is always present on output, and that
it is only...
> @@ -42,13 +42,18 @@
> # Query the state of events.
> #
> # @name: Event name pattern (case-sensitive glob).
> +# @vcpu: #optional The vCPU to check (any by default; since 2.5).
...the new input place where it is optional.
2.6.
> #
> # Returns: a list of @TraceEventInfo for the matching events
> #
> +# For any event without the "vcpu" property:
> +# - If @name is a pattern and @vcpu is set, events are ignored.
> +# - If @name is not a pattern and @vcpu is set, an error is raised.
> +#
> # Since 2.2
> ##
> { 'command': 'trace-event-get-state',
> - 'data': {'name': 'str'},
> + 'data': {'name': 'str', '*vcpu': 'int'},
> 'returns': ['TraceEventInfo'] }
>
> ##
> @@ -59,8 +64,10 @@
> # @name: Event name pattern (case-sensitive glob).
> # @enable: Whether to enable tracing.
> # @ignore-unavailable: #optional Do not match unavailable events with @name.
> +# @vcpu: The vCPU to act upon (all by default; since 2.5).
2.6
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 00/10] trace: Per-vCPU tracing states, Lluís Vilanova, 2015/11/24
- [Qemu-devel] [PATCH v2 02/10] trace: Add 'vcpu' event property, Lluís Vilanova, 2015/11/24
- [Qemu-devel] [PATCH v2 03/10] trace: [tcg] Identify events with the 'vcpu' property, Lluís Vilanova, 2015/11/24
- [Qemu-devel] [PATCH v2 05/10] exec: [ŧcg] Use multiple physical TB caches, Lluís Vilanova, 2015/11/24
- [Qemu-devel] [PATCH v2 04/10] exec: [tcg] Refactor flush of per-CPU virtual TB cache, Lluís Vilanova, 2015/11/24
- [Qemu-devel] [PATCH v2 08/10] disas: Remove unused macro '_', Lluís Vilanova, 2015/11/24
- [Qemu-devel] [PATCH v2 07/10] [trivial] Track when QEMU has finished initialization, Lluís Vilanova, 2015/11/24
- [Qemu-devel] [PATCH v2 09/10] trace: [tcg] Add per-vCPU tracing states for events with the 'vcpu' property, Lluís Vilanova, 2015/11/24
- Re: [Qemu-devel] [PATCH v2 09/10] trace: [tcg] Add per-vCPU tracing states for events with the 'vcpu' property,
Eric Blake <=
- [Qemu-devel] [PATCH v2 01/10] trace: Add support for vCPU pointers in trace events, Lluís Vilanova, 2015/11/24
- [Qemu-devel] [PATCH v2 10/10] trace: [tcg] Generate TCG code to trace guest events on a per-vCPU basis, Lluís Vilanova, 2015/11/24
- [Qemu-devel] [PATCH v2 06/10] exec: [tcg] Track which vCPU is performing translation and execution, Lluís Vilanova, 2015/11/24