Re: [Qemu-devel] [PATCH for-2.5 3/5] tests/ivshmem-test: Supply missing initializer in get_device()

[Marc-André Lureau]

----- Original Message -----
> If the device isn't found, the assertion uses dev without
> initialization.  Fix that.
> 
> Signed-off-by: Markus Armbruster <address@hidden>

my bad :)

Reviewed-by: Marc-André Lureau <address@hidden>

> ---
>  tests/ivshmem-test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/ivshmem-test.c b/tests/ivshmem-test.c
> index f1793ba..8f1a849 100644
> --- a/tests/ivshmem-test.c
> +++ b/tests/ivshmem-test.c
> @@ -40,6 +40,7 @@ static QPCIDevice *get_device(void)
>      QPCIBus *pcibus;
>  
>      pcibus = qpci_init_pc();
> +    dev = NULL;
>      qpci_device_foreach(pcibus, 0x1af4, 0x1110, save_fn, &dev);
>      g_assert(dev != NULL);
>  
> --
> 2.4.3
> 
>