qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.6 01/14] block: Add "file" output paramete


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH for-2.6 01/14] block: Add "file" output parameter to block status query functions
Date: Tue, 24 Nov 2015 13:51:06 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0


On 24/11/2015 13:50, Fam Zheng wrote:
> > > +    if (bs->file && *file == bs->file->bs &&
> > 
> > This check is unnecessary, just use "if (file)".
> 
> "file" would be bs in the case of protocol, and this function will infinitely
> recurse.

Oh, that's right!  But then I think we want to check that and allow
recursion to any *file, not just bs->file->bs.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]