[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] Don't require hw_version to be set on every
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 0/2] Don't require hw_version to be set on every machine |
Date: |
Mon, 23 Nov 2015 10:53:39 -0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
Ping? Any thoughts on this approach?
-rc2 is too late for this kind of change, maybe?
On Thu, Nov 12, 2015 at 03:29:53PM -0200, Eduardo Habkost wrote:
> This changes the qemu_hw_version() default to "2.5+" so we don't
> make every machine class broken by default unless they set
> hw_version.
>
> For reference, these are the current users of qemu_hw_version():
>
> hw/arm/nseries.c: pstrcat((void *) w, 12, qemu_hw_version()); /* char
> version[12] */
> hw/ide/core.c: pstrcpy(s->version, sizeof(s->version),
> qemu_hw_version());
> hw/scsi/megasas.c: snprintf(info.package_version, 0x60, "%s-QEMU",
> qemu_hw_version());
> hw/scsi/scsi-bus.c: pstrcpy((char *) &r->buf[32], 4,
> qemu_hw_version());
> hw/scsi/scsi-disk.c: s->version = g_strdup(qemu_hw_version());
> target-i386/cpu.c: qemu_hw_version());
>
> Cc: Andrzej Zaborowski <address@hidden>
> Cc: John Snow <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Hannes Reinecke <address@hidden>
> Cc: Richard Henderson <address@hidden>
>
> Eduardo Habkost (2):
> osdep: Change default value of qemu_hw_version() to "2.5+"
> pc: Don't set hw_version on pc-*-2.5
>
> hw/i386/pc_piix.c | 1 -
> hw/i386/pc_q35.c | 1 -
> include/hw/boards.h | 5 +++++
> include/qemu/osdep.h | 4 ++++
> util/osdep.c | 9 ++++++++-
> 5 files changed, 17 insertions(+), 3 deletions(-)
>
> --
> 2.1.0
>
>
--
Eduardo