[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Assume madvise for (no)hugepage works
|
From: |
Amit Shah |
|
Subject: |
Re: [Qemu-devel] [PATCH] Assume madvise for (no)hugepage works |
|
Date: |
Sat, 21 Nov 2015 10:30:18 +0530 |
On (Thu) 19 Nov 2015 [15:27:48], Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> madvise() returns EINVAL in the case of many failures, but also
> returns it in cases where the host kernel doesn't have THP enabled.
> Postcopy only really cares that THP is off before it detects faults,
> and turns it back on afterwards; so we're going to have
> to assume that if the madvise fails then the host just doesn't do
> THP and we can carry on with the postcopy.
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> Tested-by: Jason J. Herne <address@hidden>
Reviewed-by: Amit Shah <address@hidden>
Amit