[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-i386: Do not set MCG_SER_P by default
From: |
Borislav Petkov |
Subject: |
Re: [Qemu-devel] [PATCH] target-i386: Do not set MCG_SER_P by default |
Date: |
Sat, 21 Nov 2015 02:09:25 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Sat, Nov 21, 2015 at 12:11:35AM +0100, Andreas Färber wrote:
> Hi,
>
> CC'ing qemu-devel.
Ah, thanks.
> Am 21.11.2015 um 00:01 schrieb Borislav Petkov:
> > From: Borislav Petkov <address@hidden>
> >
> > Software Error Recovery, i.e. SER, is purely an Intel feature and it
> > shouldn't be set by default. Enable it only on Intel.
>
> Is this new in 2.5? Otherwise we would probably need compatibility code
> in pc*.[ch] for incoming live migration from older versions.
It looks it is really old, AFAIK from 2010:
c0532a76b407 ("MCE: Relay UCR MCE to guest")
You'd need to be more verbose about pc*.[ch]. An example perhaps...?
> > mcg_cap &= MCE_CAP_DEF;
> > mcg_cap |= banks;
> > +
> > + if (IS_INTEL_CPU(env))
> > + mcg_cap |= MCG_SER_P;
>
> Tabs and missing braces.
Ok.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
- Re: [Qemu-devel] [PATCH] target-i386: Do not set MCG_SER_P by default, Andreas Färber, 2015/11/20
- Re: [Qemu-devel] [PATCH] target-i386: Do not set MCG_SER_P by default,
Borislav Petkov <=
- Re: [Qemu-devel] [PATCH] target-i386: Do not set MCG_SER_P by default, Eduardo Habkost, 2015/11/23
- [Qemu-devel] MCG_CAP ABI breakage (was Re: [PATCH] target-i386: Do not set MCG_SER_P by default), Eduardo Habkost, 2015/11/23
- Re: [Qemu-devel] MCG_CAP ABI breakage (was Re: [PATCH] target-i386: Do not set MCG_SER_P by default), Borislav Petkov, 2015/11/23
- Re: [Qemu-devel] MCG_CAP ABI breakage (was Re: [PATCH] target-i386: Do not set MCG_SER_P by default), Eduardo Habkost, 2015/11/23
- Re: [Qemu-devel] MCG_CAP ABI breakage (was Re: [PATCH] target-i386: Do not set MCG_SER_P by default), Borislav Petkov, 2015/11/23
- Re: [Qemu-devel] MCG_CAP ABI breakage (was Re: [PATCH] target-i386: Do not set MCG_SER_P by default), Eduardo Habkost, 2015/11/24
- Re: [Qemu-devel] MCG_CAP ABI breakage (was Re: [PATCH] target-i386: Do not set MCG_SER_P by default), Borislav Petkov, 2015/11/24