[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 02/10] qom: Introduce ObjectPropertyIterator stru
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PULL 02/10] qom: Introduce ObjectPropertyIterator struct for iteration |
Date: |
Thu, 19 Nov 2015 14:42:13 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Andreas Färber <address@hidden> writes:
> Am 19.11.2015 um 10:20 schrieb Markus Armbruster:
>> Andreas Färber <address@hidden> writes:
>>
>>> From: "Daniel P. Berrange" <address@hidden>
>>>
>>> Some users of QOM need to be able to iterate over properties
>>> defined against an object instance. Currently they are just
>>> directly using the QTAIL macros against the object properties
>>> data structure.
>>>
>>> This is bad because it exposes them to changes in the data
>>> structure used to store properties, as well as changes in
>>> functionality such as ability to register properties against
>>> the class.
>>>
>>> This provides an ObjectPropertyIterator struct which will
>>> insulate the callers from the particular data structure
>>> used to store properties. It can be used thus
>>>
>>> ObjectProperty *prop;
>>> ObjectPropertyIterator *iter;
>>>
>>> iter = object_property_iter_init(obj);
>>> while ((prop = object_property_iter_next(iter))) {
>>> ... do something with prop ...
>>> }
>>> object_property_iter_free(iter);
>>
>> I see my review hasn't been addressed,
>
> Well, it has, I double-checked that the missing "Iterator" above was
> already on my branch, therefore my IRC comment pointing you to qom-next.
>
>> probably because it came late.
>
> Other than that you only seemed to discuss design alternatives, for
> which neither you nor Daniel provided any actual patch I could've
> applied. While I regularly do style fixups myself, and with the series
> missing -rc0 also functional fixes, posting a diff for review/record, I
> do not see redesigning a 6-patch series as something I can silently do
> last-minute without full respin, for which -rc1 did not leave time.
I certainly didn't expect you to address my review yourself. You
could've replied with a short note asking Dan to address the remainder
of my review in a follow-up patch. But no harm done, because I'm not
shy following up about remainders of my reviews myself.
> There was a v3 with iterators, and Pavel pinged v4 twice, I did once
> too, and the last delay after getting the series to work was only due to
> me inserting Daniel's test case (legit hardfreeze material), so ...
>
>> Would you accept a follow-up patch to bring the iterator into line with
>> existing ones?
>
> ... yes, from my perspective any such cleanups can be done post-2.5.
By now should be done, even.
> Please note that both patch 6/7 (included) and 7/7 (not in this pull)
> enhance the iterator, so follow-up patches should be based on qom-next
> please.
>
> Thanks,
> Andreas
- [Qemu-devel] [PULL 01/10] qdev: Change Property::offset field to ptrdiff_t type, (continued)
- [Qemu-devel] [PULL 01/10] qdev: Change Property::offset field to ptrdiff_t type, Andreas Färber, 2015/11/18
- [Qemu-devel] [PULL for-2.5 00/10] QOM devices patch queue 2015-11-18, Andreas Färber, 2015/11/18
- [Qemu-devel] [PULL 01/10] qdev: Change Property::offset field to ptrdiff_t type, Andreas Färber, 2015/11/18
- [Qemu-devel] [PULL 03/10] qmp: Convert QMP code to use object property iterators, Andreas Färber, 2015/11/18
- [Qemu-devel] [PULL 04/10] vl: Convert machine help code to use object property iterators, Andreas Färber, 2015/11/18
- [Qemu-devel] [PULL 02/10] qom: Introduce ObjectPropertyIterator struct for iteration, Andreas Färber, 2015/11/18
- Re: [Qemu-devel] [PULL 02/10] qom: Introduce ObjectPropertyIterator struct for iteration, Andreas Färber, 2015/11/19
- Re: [Qemu-devel] [PULL 02/10] qom: Introduce ObjectPropertyIterator struct for iteration,
Markus Armbruster <=
[Qemu-devel] [PULL 06/10] net: Convert net filter code to use object property iterators, Andreas Färber, 2015/11/18
[Qemu-devel] [PULL 08/10] qom: Replace object property list with GHashTable, Andreas Färber, 2015/11/18
[Qemu-devel] [PULL 05/10] ppc: Convert spapr code to use object property iterators, Andreas Färber, 2015/11/18
[Qemu-devel] [PULL 10/10] MAINTAINERS: Add check-qom-{interface, proplist} to QOM, Andreas Färber, 2015/11/18
[Qemu-devel] [PULL 09/10] qom: Clean up assertions to display values on failure, Andreas Färber, 2015/11/18
[Qemu-devel] [PULL 07/10] qom: Add a test case for complex property finalization, Andreas Färber, 2015/11/18
Re: [Qemu-devel] [PULL for-2.5 00/10] QOM devices patch queue 2015-11-18, Peter Maydell, 2015/11/19