[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/3] target-i386: add pkeys support for cpuid
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/3] target-i386: add pkeys support for cpuid handling |
Date: |
Thu, 19 Nov 2015 12:10:49 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 19/11/2015 07:36, Han, Huaitong wrote:
> I understand it has always been that QEMU considers the feature of
> cpuid_7_0_ecx_feature_name as migratable. If the feature is
> unmigratable, it will been added to unmigratable_flags.
>
> A series of patches do complete a full function, moving
> cpuid_7_0_ecx_feature_name to 2/3 patch may make 2/3 patch look
> better, but make 1/3 patch look somewhat incomplete.
>
> Maybe it is a solution that adding the feature to unmigratable_flags in
> 1/3 patch, and deleting unmigratable_flags in 2/3 patch, but I think it
> is pointless.
Or just squash everything together. After all we're talking of
4 files changed, 55 insertions(+), 1 deletion(-)
It's not a large patch.
Paolo
[Qemu-devel] [PATCH v3 2/3] target-i386: add pkeys support for xsave state handling, Huaitong Han, 2015/11/17
[Qemu-devel] [PATCH v3 3/3] target-i386: add pkeys support for vm migration, Huaitong Han, 2015/11/17
Re: [Qemu-devel] [PATCH v3 0/3] target-i386: add memory protection-key support, Eduardo Habkost, 2015/11/18