Re: [Qemu-devel] [PATCH 05/18] armv7m: expand NVIC state

[Peter Maydell]

On 9 November 2015 at 01:11, Michael Davidsaver <address@hidden> wrote:
> Expand the NVIC to fully support -M priorities and masking.
> Doesn't use GIC code.
>
> Move some state to ARMCPU to allow calculation of exception masking.
>
> Add storage for PRIGROUP to configure group/sub-group split.
> Track group and sub-group in separate fields for quick comparison.
> Mix in vector # with sub-group as per tie breaking rules.
>
> NVIC now derives directly from SysBusDevice, and
> struct NVICClass is eliminated.
>
> Also add DPRINTF() macro.
>
> Signed-off-by: Michael Davidsaver <address@hidden>

This patch doesn't compile, because you've removed the definition of
NVICClass, NVIC_CLASS, etc, but not their uses. A patchset needs to
compile after every patch in it, not just at the end when all patches
are applied. You'll need to rearrange your changes between patches
a bit.

thanks
-- PMM